Add support for binding Memory and ReadOnlyMemory#37485
Merged
roji merged 2 commits intodotnet:mainfrom Jan 12, 2026
Merged
Conversation
Member
joelverhagen
commented
Jan 11, 2026
joelverhagen
commented
- I've read the guidelines for contributing and seen the walkthrough
- I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
- Feel free to close the PR if this change is not desired.
- The code builds and tests pass locally (also verified by our automated build checks)
- Commit messages follow this format:
- Fixes Support Memory and ReadOnlyMemory parameter binding in Microsoft.Data.Sqlite #37484
- Tests for the changes have been added (for bug fixes / features)
- Code follows the same patterns and style as existing code in this repo
There was a problem hiding this comment.
Pull request overview
This PR adds support for binding Memory<byte> and ReadOnlyMemory<byte> types as SQLite parameters, addressing issue #37484. The implementation allows these modern memory types to be used interchangeably with byte arrays when binding parameter values.
Changes:
- Extended
SqliteValueBinder.Bind()method to handleMemory<byte>andReadOnlyMemory<byte>by extracting their spans - Added type mappings for both memory types to
SqliteType.Blobin the type mapping dictionary - Added comprehensive tests for both memory types, including slice operations and type inference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.Sqlite.Core/SqliteValueBinder.cs | Added binding logic for Memory and ReadOnlyMemory types, plus type mappings to SqliteType.Blob |
| test/Microsoft.Data.Sqlite.Tests/SqliteParameterTest.cs | Added functional tests for Memory and ReadOnlyMemory binding with slice operations, plus type inference tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.